Separate helm stuff from pure (/reusable) crd definitions

[jkremser]

Fixes #925

Using helm's $files.Get to include those two CRDs based on the k8gb.deployCrds flag. This way we can have pure CRDs that are also deployable w/o helm (or remotely referencing the github url)

side note: there is also a line with $$(( $(CLUSTERS_NUMBER) + 1 )), because when doing full local setup, we are actually deploying n+1 clusters (+1 for the edge dns cluster)

Signed-off-by: Jirka Kremser [email protected]

[kuritka]

Awesome, thanks 👍 !

Please check my review comment

[kuritka]

does --- needs to be here ? When brackets were used my controller-gen move it unintentionally. I mean, it looks unnecessary and controllergen can move it again in the future.

[jkremser]

I had a mistake in my previous version of the PR.. it was appending the crds for k8gb to that file, now it's only > instead of >>.

--- at the beginning is what controller-gen crd:crdVersions=v1 paths="./..." output:crd:stdout actually produces, I am not sure what you mean by "controllergen can move it" (perhaps it was the issue with append instead of rewrite logic?)

[kuritka]

@jkremser , thx for clarification.

[jkremser]

thanks for the review, good catch actually 👍