Helm values schema check #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <[email protected]>
…json schema Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
kuritka
requested changes
Sep 9, 2022
|
meh, applying your suggestion broke it... the comment is missing. Will fix that on Monday + I was actually happier with the original form since it's only based on this idea, however the implementaion is totally different |
jkremser
force-pushed
the
helm-values-schema-check
branch
from
50505b8 to
5411657
Compare
kuritka
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there is a change to
values.yamlorvalues.schema.json, this workflow will verify thatvalues.yamlfile is still valid against the corresponding JSON schema.I had to remove those
required: []lines because the python tool was failing on them. Semantically it's the same, these lines were actually redundant.