Get rid of set-output commands in the workflows

[jkremser]

Fixes #965

as suggested here and here, the echo "::set-output name=foo::${bar}" should be replaced with echo foo=bar >> $GITHUB_ENV and then read as normal env var in all subsequent steps in the same job.

[kuritka]

Hi, can't this generate some kind of scope issues ? ENV exists once for whole workflow run while step.. points to property of concrete instance.

Anyway, using env certainly simplifies the usage.

[jkremser]

@kuritka what do you mean by scope issues? I agree that the semantics is different here and previously it was better isolated in the step itself. I haven't tested the behavior, but I can imagine that it's appending key=value entries to some env file which is being sourced at the beginning of each subsequent step (it's not available for the step itself in which we do the thing).

So I think the latter occurrences will override the previous ones, but I didn't test it. Anyway we do not do that nor are relying on such behavior AFAICT. One can also set the env vars explicitly for whole job but also for each step, in this case I have no idea about the precedence rules, it's not well documented either. For sharing the data between the jobs this will not work at all, it's designed to work under one job and for that use-case one has to use job outputs.

[kuritka]

lgtm

[somaritane]

@kuritka we're basically following GH standard recommendations here for deprecated output commands

[somaritane]

lgtm

[kuritka]

@somaritane - thx I see. I read it in links @jkremser mentioned in description. I'm convinced that the change is right.

[ytsarev]

LGTM

[jkremser]

sorry, I forgot to change the way how verbose flag was read in the print-debug action so I am adding a new commit: 1a9c02c to fix it.

The rest is the same as before, the review should be easier this way, in the end I will squash the changes.