Non deterministic round robin demo #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
force-pushed
the
#69-nd-round-robin-MERGE
branch
from
418be1e to
382d20f
Compare
ytsarev
requested changes
Apr 23, 2020
kuritka
force-pushed
the
#69-nd-round-robin-MERGE
branch
from
382d20f to
914408c
Compare
ytsarev
reviewed
Apr 24, 2020
| .PHONY: test-round-robin | ||
| test-round-robin: | ||
| @kubectl run -it --rm busybox --restart=Never --image=busybox -- sh -c \ | ||
| "echo 'nameserver `$(OHMYGLB_COREDNS_IP)`' > /etc/resolv.conf && \ |
There was a problem hiding this comment.
why backtics are required here >
There was a problem hiding this comment.
@ytsarev because OHMYGLB_COREDNS_IP is not environment variable but GNU make variable which is kubectl command
OHMYGLB_COREDNS_IP ?= kubectl get svc ohmyglb-coredns -n ohmyglb -o custom-columns='IP:spec.clusterIP' --no-headers
with backtics it will proceed like:
@kubectl run -it --rm busybox --restart=Never --image=busybox -- sh -c \
"echo 'nameserver `kubectl get svc ohmyglb-coredns -n ohmyglb -o custom-columns='IP:spec.clusterIP' --no-headers`' > /etc/resolv.conf &&
ytsarev
reviewed
Apr 24, 2020
ytsarev
reviewed
Apr 24, 2020
ytsarev
requested changes
Apr 24, 2020
test script set podinfo region README.md merge makefile merge
kuritka
force-pushed
the
#69-nd-round-robin-MERGE
branch
from
914408c to
a2cbef4
Compare
ytsarev
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
alter non deterministic round-robin demo for users to be able to test by their own