Skip to content

Commit

Permalink
update breaker version and examples, add deps and goimports target
Browse files Browse the repository at this point in the history
  • Loading branch information
kamilsk committed Feb 18, 2019
1 parent c7badc5 commit 9f04277
Show file tree
Hide file tree
Showing 14 changed files with 178 additions and 150 deletions.
9 changes: 9 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
SHELL := /bin/bash -euo pipefail


.PHONY: deps
deps:
@(go mod tidy && go mod vendor && go mod verify)


.PHONY: generate
generate:
go generate ./cmd/generate
mv ./cmd/generate/parser_gen.go ./cmd/retry/parser_gen.go

.PHONY: goimports
goimports:
@(goimports -ungroup -w .)


.PHONY: test
test: #| Runs tests with race.
Expand Down
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,9 @@ action := func(ctx context.Context, _ uint) error {
response, err = http.DefaultClient.Do(req)
return err
}
ctx := breaker.WithContext(
context.Background(),
breaker.BreakBySignal(os.Interrupt),
)
ctx, _ := context.WithTimeout(request.Context(), time.Minute)
br, ctx := breaker.WithContext(ctx)
defer br.Close()

if err := retry.TryContext(ctx, action, strategy.Limit(3)); err != nil {
// handle error
Expand Down
7 changes: 3 additions & 4 deletions cmd/retry/examples/example_quickstart_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,9 @@ func ExampleTryContextQuickStart() {
response, err = http.DefaultClient.Do(req)
return err
}
ctx := breaker.WithContext(
context.Background(),
breaker.BreakBySignal(os.Interrupt),
)
ctx, _ := context.WithTimeout(context.Background(), time.Minute)
br, ctx := breaker.WithContext(ctx)
defer br.Close()

if err := retry.TryContext(ctx, action, strategy.Limit(3)); err != nil {
log.Fatal(err)
Expand Down
1 change: 1 addition & 0 deletions cmd/retry/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module github.com/kamilsk/retry/cli

require (
github.com/briandowns/spinner v0.0.0-20190212173954-5cf08d0ac778
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/fatih/color v1.7.0
github.com/inconshreveable/mousetrap v1.0.0 // indirect
github.com/kamilsk/breaker v1.0.0
Expand Down
5 changes: 3 additions & 2 deletions cmd/retry/go.sum
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
github.com/briandowns/spinner v0.0.0-20190212173954-5cf08d0ac778 h1:Dmz6bJXocvwkw7BOz4jpyVZReGrkjs+fBDWKn5tBES4=
github.com/briandowns/spinner v0.0.0-20190212173954-5cf08d0ac778/go.mod h1:hw/JEQBIE+c/BLI4aKM8UU8v+ZqrD3h7HC27kKt8JQU=
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys=
github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM=
github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8=
github.com/kamilsk/breaker v1.0.0 h1:5c1qEzpnlqhZtbuHzAb//Pgqe7C3sDAwI2+qbjpsQPw=
github.com/kamilsk/breaker v1.0.0 h1:Hj1n5Y6YeYLB/MTbrS1+xU1b5qjSnIhDz5MO2NyNDJA=
github.com/kamilsk/breaker v1.0.0/go.mod h1:v9ySMER3LyAafxjouLF3PLF2bueyFIMXSTWEMa16hdE=
github.com/kamilsk/go-kit v0.0.0-20190129050637-e2e228a63f53 h1:6aZQZCuXNZpWfGa2yjMRU83msPNdlg3sP8pzxHUCQH8=
github.com/kamilsk/go-kit v0.0.0-20190129050637-e2e228a63f53/go.mod h1:h4x6B1xj2nw89zH4cRlNFfH1B1VF67fx/sL/F3ASpNA=
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9f04277

Please sign in to comment.