Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitmap to v1.1.0 #11

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Bitmap to v1.1.0 #11

merged 2 commits into from
Jun 30, 2021

Conversation

kelindar
Copy link
Owner

This PR upgrades the bitmap dependency which has performance improvements to both Range() and Filter() methods by roughly 20% and 5% respectively. Interestingly, this specific benchmark is actually 50% faster.

players.Query(func(txn *Txn) error {
   txn.WithString("race", func(v string) bool {
       return v == "human"
   }).WithString("class", func(v string) bool {
       return v == "mage"
   }).WithFloat("age", func(v float64) bool {
       return v >= 30
   }).Count()
    return nil
})

The reason being is that the second and third scans contain a lot of "holes" in the bitmap and the new implementation quickly skips empty pages and consecutive zero bits.

@kelindar kelindar merged commit 67ec4b8 into main Jun 30, 2021
@kelindar kelindar deleted the bitmap branch June 30, 2021 21:05
sthagen added a commit to sthagen/kelindar-column that referenced this pull request Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant