Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case when union is first called indexing function #56

Merged
merged 1 commit into from
May 7, 2022

Conversation

Dreeseaw
Copy link
Collaborator

When a transaction is first initialized, the internal index is set to the owner collection's fill list. When a Union call is applied to this fresh transaction, the index either remains unchanged or now marks unfilled bits as filled.

@Dreeseaw
Copy link
Collaborator Author

fixes #54

@Dreeseaw Dreeseaw changed the title Fix case when union is first called indexing function (issue #54) Fix case when union is first called indexing function Apr 14, 2022
@Dreeseaw
Copy link
Collaborator Author

Requesting review @kelindar

Copy link
Owner

@kelindar kelindar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@kelindar kelindar merged commit e1c0f3f into kelindar:main May 7, 2022
@Dreeseaw Dreeseaw deleted the union-bug branch May 24, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants