Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swap and record index #76

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Fix swap and record index #76

merged 1 commit into from
Dec 1, 2022

Conversation

kelindar
Copy link
Owner

@kelindar kelindar commented Dec 1, 2022

Bugfixes

  • Swap... was not properly swapping when an underlying buffer was re-allocated due to append()
  • Index for Record types was not working when strings are being merged due to the fact that it could not see the newly appended values.

Optimizations

  • When swapping strings, if the string is of exactly the same size as before, it will be swapped in-place (same as for other values).

@kelindar kelindar merged commit 501708a into main Dec 1, 2022
@kelindar kelindar deleted the fix-swap branch December 1, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant