Faster filtering #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up filtering by around
10-15%by avoiding calling toContainson each item in thefilllist. Instead, we do a SIMD-acceleratedANDright before the filter loop, cutting out all of the elements that are not present out of the index. The benchmarks are conservative, and thisANDoperation doesn't actually eliminate anything since all of the rows have the column.Not only it removes the
Containscalls but also in the case of numbers it should reduce branch mispredictions as there's no more branches during the filter, but I haven't checked the numbers.