-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make transport-encryption a Beta feature #7915
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7915 +/- ##
==========================================
- Coverage 69.22% 69.02% -0.20%
==========================================
Files 339 341 +2
Lines 19494 15853 -3641
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4236 -1101
- Partials 663 674 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierDipi should we also update:
test/config/config-features.yaml
- The experimental feature docs page?
No, this still needs to be tested separately
Yes, I'm working on the updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold in case you want reviews from anyone else @pierDipi
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
it will still be disabled by default as we can't really enable it automatically
given that it depends on the cert-manager installation and a few more
setup prerequisites.
Pre-review Checklist
Release Note
Docs
knative/docs#5967