-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add deprecated argument to derive macro #1697
Conversation
Signed-off-by: Techassi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
+ Coverage 75.9% 75.9% +0.1%
=======================================
Files 84 84
Lines 7679 7685 +6
=======================================
+ Hits 5822 5827 +5
- Misses 1857 1858 +1
|
The single missing line is a bummer. I thought this is covered by the doc test. Seems like codecov isn't considering doc tests when calculating coverage. Let me know if there is a way to test the single missing line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! quick nit on docs
Signed-off-by: Techassi <[email protected]>
Co-authored-by: Eirik A <[email protected]> Signed-off-by: Techassi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Will merge at green. Thank you!
Lovely, thank you for the quick review :) |
Motivation
Currently it is not possible to set the
deprecated
anddeprecationWarning
of a particular CRD version using the derive macro.See the official Kubernetes docs.
Solution
This PR adds one new argument to the derive macro to set one or both properties.