Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify keybindings #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jan 4, 2021

No description provided.

@kwrooijen
Copy link
Owner

Maybe we can add the simplified keys in parallel with the originals? That way we don't break anyone's workflow and we get the simplified keys. What do you think?

@mookid
Copy link
Contributor

mookid commented Jan 4, 2021

it seems a little fishy to me. In my opinion, we should either break everyone now (and document how to unbreak users in readme) or document how to change the default and stick to it.

@kwrooijen
Copy link
Owner

kwrooijen commented Jan 4, 2021

I'm not a fan breaking changes. If people want to change the keybindings they can. But I don't have a view of how many people actually use this package and the original keybindings. If we do decide to change it, maybe copy the spacemacs standard?

https://github.com/syl20bnr/spacemacs/blob/ee9201efe789e1f1dbff3c15aa9e394265c664e1/layers/%2Blang/rust/packages.el#L35-L57

@ayrat555
Copy link
Contributor Author

ayrat555 commented Jan 4, 2021

I'm ok with any variant.

Another approach can be creating a new library and deprecate this one. IMHO I think breaking workflow for some users if we provide a better workflow is ok.

Also, does elpa provide updates based on major version of the library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants