Add support for rust-ts-mode to cargo-process--get-current-test #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemethf
reviewed
Oct 20, 2023
| (t (user-error "%s needs either rust-mode or rustic-mode" | ||
| ((fboundp 'treesit-beginning-of-defun) | ||
| (treesit-beginning-of-defun)) | ||
| (t (user-error "%s needs either rust-mode, rustic-mode, or rust-ts-mode" | ||
| this-command)))) | ||
| (beginning-of-line) | ||
| (search-forward "fn ") |
There was a problem hiding this comment.
instead of this, would it be more robust (and more elegant) to find the function name with something like this:
(re-search-forward "fn\\s +\\(.*\\_>\\)")
(match-string 1)Additionally, the defun does not return the current test, it returns the name of the current function.
There was a problem hiding this comment.
I mean instead of the (search-forward "fn ") part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs 29 has a new mode
rust-ts-mode.Currently,
cargo-process--get-current-testdoesn't work in that mode.This change adds support for the mode to the command.