Add user_segment_id and permission_group_id as arguments to create HelpCenter article #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolly7nap3
commented
Jul 12, 2019
| @@ -45,6 +45,10 @@ class Zendesk2::HelpCenter::Article | |||
| attribute :vote_count, type: :integer # ro:yes required:no | |||
| # @return [Integer] The total sum of votes on this article | |||
| attribute :vote_sum, type: :integer # ro:yes required:no | |||
| # @return [Integer] The id of the user segment which defines who can see this article | |||
| attribute :user_segment_id, type: :integer, default: nil # ro:no required:yes | |||
There was a problem hiding this comment.
According to the documentation, user_segment_id is required but can be nil.
So, I set nil if user_segment_id is not given.
jolly7nap3
force-pushed
the
fix_helpcenter_article_argument
branch
from
9381414 to
fa04d4c
Compare
|
@lanej I would like to ask you to review these changes. |
|
Sorry for the delay. Thanks @jolly7nap3 |
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in the JSON Format of Help Center Article.
The following items were added as required.
ref. https://developer.zendesk.com/rest_api/docs/help_center/articles
This PR follows the above changes.