Desktop: Fix viewer and panel plugins that check for the presence of exports
fail to load
#10900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit c197a83. See this issue report on the forum.
The Function Plot plugin (and possibly other plugins) check whether a variable called
exports
exists to determine whether running in a NodeJS or browser environment, then export content accordingly.c197a83 had the effect of fixing a nonfatal error in plugins that use the default plugin template. An alternate approach could be to modify the default plugin template to target
web
instead ofnode
for panel/dialog/viewer scripts. See the forum post for more details.Testing plan