Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile,Desktop: Fixes #10914: Fix BMP image rendering in the Markdown viewer #10915

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Aug 21, 2024

Summary

This pull request adds image/bmp to the list of supported resource formats.

Note: The Rich Text Editor replaces resource URLs before checking whether an image is in a supported format (replaceResourceInternalToExternalLinks is true), so this only affects the Markdown editor.

This pull request fixes #10914.

Note: I have observed the original issue on both desktop and web.

Testing plan

  1. Create a new note and attach a BMP image.
  2. Verify that the BMP image renders in the Markdown viewer.

This has been tested successfully on Linux (Fedora 40) and web (Chromium).

@laurent22 laurent22 merged commit 580d291 into laurent22:dev Aug 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MD Render Pane does not display BMP files. RTE does.
2 participants