Windows,Linux: Fix keyboard can't add text after certain error/info dialogs are shown #11603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request replaces several uses of
alert
in packages/app-desktop with the asyncshim.showMessageBox
orshim.showErrorDialog
equivalents.This works around this upstream Electron issue related to
alert()
.Note: See #11241 for a similar change made previously.
Testing plan
Fedora Linux: