Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows,Linux: Fix keyboard can't add text after certain error/info dialogs are shown #11603

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 7, 2025

Summary

This pull request replaces several uses of alert in packages/app-desktop with the async shim.showMessageBox or shim.showErrorDialog equivalents.

This works around this upstream Electron issue related to alert().

Note: See #11241 for a similar change made previously.

Testing plan

Fedora Linux:

  1. Click Help > Copy dev mode command to clipboard.
  2. Click on the note title input.
  3. Type.
  4. Verify that the typed text is added to the note title input.
  5. Open the webclipper config screen.
  6. Click "copy token".
  7. Open the "Appearance" tab.
  8. Focus the "Editor maximum width" input.
  9. Type a number.
  10. Verify that the editor maximum width input is updated.
  11. Open the note revision viewer.
  12. Restore a revision.
  13. Verify that it's possible to type text in the title input.
  14. Open the encryption config screen.
  15. Click "Clear master password".
  16. Open the master password dialog.
  17. Enter an incorrect password.
  18. Click "save".
  19. Verify that an error dialog with the message "Master password is not valid. Please try again" and an "OK" button is shown.
  20. Enter the correct password and click "save".
  21. Disconnect from Joplin Server (e.g. by stopping the Server instance).
  22. Right-click on a shared notebook and click "Leave notebook".
  23. Click "OK".
  24. Verify that it's still possible to edit the note title input.
  25. Open settings > appearance.
  26. Change a setting.
  27. Switch to the "Encryption" tab.
  28. In the "This will open a new screen" dialog, click "Ok".
  29. Close settings.
  30. Verify that it's still possible to edit the note title input.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review January 7, 2025 23:07
@laurent22 laurent22 merged commit e1e2ba8 into laurent22:dev Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants