Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #11640: Pressing Shift+Tab when focus is on notebook list would jump straight to editor #11641

Merged

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Jan 14, 2025

Fixes #11640

Summary

According to the WCAG 2.4.3 guideline the order of navigation of elements should be predictable, so we should avoid programmatically choosing which element should be focused when navigating with Tab and Shift+Tab

Testing

  1. Open editor
  2. Add focus to the notebook list
  3. Press Shift+Tab
  4. Focus should go to Add new Notebook button

@pedr pedr added bug It's a bug accessibility Related to accessibility labels Jan 14, 2025
@pedr pedr requested a review from laurent22 January 16, 2025 13:56
@laurent22 laurent22 merged commit 29e55b8 into laurent22:dev Jan 18, 2025
7 checks passed
@pedr pedr deleted the aria-disable-shift-tab-focusing-editor branch January 20, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility bug It's a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing shift-tab from the notebook list causes focus to jump to the editor. (SC 2.4.3)
3 participants