Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix datetime values not appearing on note properties when the picker is open #11748

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Jan 29, 2025

Summary

When adding the react-datetime I end up not properly testing, introducing the bug where the datetime value is not visible when the datetime-local picker is open. To fix that I removed all the values transformation adding the date/time format chosen by the user only when the value is being shown.

image

After the fix:

2025-01-25_14-34_1

Testing

  1. Open Note Properties
  2. Press on the edit button on Created, Updated or Completed
  3. See if the date picker is set to the correct date and time

Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me! I've left two minor comments.

@personalizedrefrigerator personalizedrefrigerator added bug It's a bug desktop All desktop platforms labels Jan 29, 2025
@pedr
Copy link
Collaborator Author

pedr commented Jan 30, 2025

  • Look at refactor: key.indexOf('_time') >= 0 || key === 'todo_completed'

@laurent22 laurent22 merged commit e36a30e into laurent22:dev Feb 6, 2025
7 checks passed
@pedr pedr deleted the fix-note-properties branch February 7, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants