routerrpc: fix estimateroutefee for public route hints #9433

hieblmi · 2025-01-22T15:07:06Z

This PR attempts to fix #9431, an edge case in EstimateRouteFee.

We want to send a probe in case a route hint contains a public edge.

coderabbitai · 2025-01-22T15:07:14Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ziggie1984

Thanks for the quick fix, looking good.

I think a unit-test might be worthwhile for the new behaviour.

lnrpc/routerrpc/router_backend.go

lnrpc/routerrpc/router_server.go

rpcserver.go

lnrpc/routerrpc/router_server_test.go

lnrpc/routerrpc/router_backend.go

bitromortac

Concept ACK, in principle, a single public hop hint doesn't lead to fee estimation errors, I think. The advantage in checking if we know the last hop is that we'll also probe it and know if it supports the payment as opposed to the case when we assume an LSP.

lnrpc/routerrpc/router_server.go

lnrpc/routerrpc/router_backend.go

bitromortac · 2025-01-24T10:35:11Z

lnrpc/routerrpc/router_server.go

 	if len(routeHints) == 0 || len(routeHints[0]) == 0 {
 		return false
 	}

-	refNodeID := routeHints[0][len(routeHints[0])-1].NodeID
+	refHint := routeHints[0][len(routeHints[0])-1]


could we rename the ref prefixes to something that's more explanatory?

still ref used ?

renamed it to destHopHint and also referenced that in the comments.

ziggie1984

Nice, LGTM.

Please update the documentation otherwise good-to-go

docs/release-notes/release-notes-0.19.0.md

ziggie1984 · 2025-02-07T19:40:04Z

lnrpc/routerrpc/router_server.go

 	if len(routeHints) == 0 || len(routeHints[0]) == 0 {
 		return false
 	}

-	refNodeID := routeHints[0][len(routeHints[0])-1].NodeID
+	refHint := routeHints[0][len(routeHints[0])-1]


still ref used ?

lnrpc/routerrpc/router_server_test.go

lnrpc/routerrpc/router_server.go

lightninglabs-deploy · 2025-02-17T00:21:47Z

@gijswijs: review reminder
@bitromortac: review reminder

gijswijs

Had 1 question and 1 remark: I think there's an unneeded definition in the lspTestCases struct. I would just remove it.
Apart from that, LGTM 🎉

gijswijs · 2025-02-20T13:45:43Z

lnrpc/routerrpc/router_server_test.go

+	}
+
+	// Returns ErrEdgeNotFound for private channels.
+	fetchChannelEndpoints := func(chanID uint64) (route.Vertex,


👍 Nice mock func.

gijswijs · 2025-02-20T13:49:01Z

lnrpc/routerrpc/router_server_test.go

@@ -284,6 +294,7 @@ func TestIsLsp(t *testing.T) {
 		isLsp          bool
 		expectedHints  [][]zpay32.HopHint
 		expectedLspHop *zpay32.HopHint
+		channelID      uint64


Why is channelID defined? It appears to not been used anywhere.

gijswijs · 2025-02-20T13:51:26Z

lnrpc/routerrpc/router_server.go

-func isLSP(routeHints [][]zpay32.HopHint) bool {
+// true if the destination hop hint in each route hint has the same node id,
+// false otherwise. If the destination hop hint of the first route hint contains
+// a public channel, the function returns false because we can directly send a


For my understanding, if there is a public channel in the route hints, it is always in the first route hint?

Not necessarily, I think it would be more robust if we'd check if we know about any last hop to exclude an LSP, because a receiver could in principle mix private and public channels. I think it's also not too inefficient since we only have to check a few hints most of the time. So we should catch the case [[private via nodeX], [public via nodeX], [public via nodeX]] to not classify nodeX as an LSP, which could be added as a test.

Thanks @gijswijs and @bitromortac for this improvement to the robustness of isLSP. I've added the public channel check for each final hop hint of each route hint as suggested and added a testcase to cover it.

bitromortac

Nice, I think it would be better to check if we know any public last hop to rule out an LSP, see comment, other than that, it looks good 🙏.

bitromortac · 2025-02-20T14:20:26Z

lnrpc/routerrpc/router_server.go

-func isLSP(routeHints [][]zpay32.HopHint) bool {
+// true if the destination hop hint in each route hint has the same node id,
+// false otherwise. If the destination hop hint of the first route hint contains
+// a public channel, the function returns false because we can directly send a


Not necessarily, I think it would be more robust if we'd check if we know about any last hop to exclude an LSP, because a receiver could in principle mix private and public channels. I think it's also not too inefficient since we only have to check a few hints most of the time. So we should catch the case [[private via nodeX], [public via nodeX], [public via nodeX]] to not classify nodeX as an LSP, which could be added as a test.

hieblmi requested a review from ziggie1984 January 22, 2025 15:07

hieblmi self-assigned this Jan 22, 2025

hieblmi marked this pull request as draft January 22, 2025 15:07

hieblmi force-pushed the estimate-route-fee-fix branch 2 times, most recently from b3d97b5 to eb1d56a Compare January 22, 2025 16:23

ziggie1984 added this to the v0.19.0 milestone Jan 22, 2025

ziggie1984 requested changes Jan 22, 2025

View reviewed changes

ziggie1984 reviewed Jan 22, 2025

View reviewed changes

lnrpc/routerrpc/router_backend.go Outdated Show resolved Hide resolved

saubyk requested a review from bitromortac January 23, 2025 15:48

bitromortac reviewed Jan 24, 2025

View reviewed changes

hieblmi marked this pull request as ready for review February 4, 2025 17:12

saubyk requested a review from gijswijs February 4, 2025 17:48

hieblmi force-pushed the estimate-route-fee-fix branch 2 times, most recently from 7be7d83 to ec2132b Compare February 7, 2025 11:33

hieblmi requested review from bitromortac and ziggie1984 February 7, 2025 12:30

ziggie1984 approved these changes Feb 7, 2025

View reviewed changes

hieblmi force-pushed the estimate-route-fee-fix branch from ec2132b to 8c8e852 Compare February 8, 2025 16:52

gijswijs approved these changes Feb 20, 2025

View reviewed changes

bitromortac reviewed Feb 20, 2025

View reviewed changes

hieblmi added 2 commits February 21, 2025 14:43

routerrpc: fix estimateroutefee for public route hints

993f2f9

docs: update release notes

4ecb5e8

hieblmi force-pushed the estimate-route-fee-fix branch from 8c8e852 to 4ecb5e8 Compare February 21, 2025 13:43

hieblmi requested review from bitromortac and gijswijs February 21, 2025 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

routerrpc: fix estimateroutefee for public route hints #9433

routerrpc: fix estimateroutefee for public route hints #9433

hieblmi commented Jan 22, 2025 •

edited

Loading

coderabbitai bot commented Jan 22, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

ziggie1984 left a comment

bitromortac left a comment

bitromortac Jan 24, 2025

ziggie1984 Feb 7, 2025

hieblmi Feb 8, 2025 •

edited

Loading

ziggie1984 left a comment

ziggie1984 Feb 7, 2025

lightninglabs-deploy commented Feb 17, 2025

gijswijs left a comment

gijswijs Feb 20, 2025

gijswijs Feb 20, 2025

hieblmi Feb 21, 2025

gijswijs Feb 20, 2025

bitromortac Feb 20, 2025

hieblmi Feb 21, 2025

bitromortac left a comment

bitromortac Feb 20, 2025

routerrpc: fix estimateroutefee for public route hints #9433

Are you sure you want to change the base?

routerrpc: fix estimateroutefee for public route hints #9433

Conversation

hieblmi commented Jan 22, 2025 • edited Loading

coderabbitai bot commented Jan 22, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

ziggie1984 left a comment

Choose a reason for hiding this comment

bitromortac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hieblmi Feb 8, 2025 • edited Loading

Choose a reason for hiding this comment

ziggie1984 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lightninglabs-deploy commented Feb 17, 2025

gijswijs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bitromortac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hieblmi commented Jan 22, 2025 •

edited

Loading

coderabbitai bot commented Jan 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

hieblmi Feb 8, 2025 •

edited

Loading