Skip to content

Bug: run_app silently returns a URL to the user even if startup fails #4021

Open
@marcuslimdw

Description

Description

testing.client.subprocess_client.run_app loops 100 times while checking if the hosted app is up. Crucially, if the app is not up after those 100 iterations. it still yields the putative app URL to the consuming test, which will most likely get a "connection refused" or similar error.

I think the correct behaviour here is instead to raise an error (something to the effect of "app failed to start"); perhaps this could be a customisable timeout that determines how many iterations before failure...?

Litestar Version

2.14.0

Platform

  • Linux
  • Mac
  • Windows
  • Other (Please specify in the description above)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Bug 🐛This is something that is not working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions