Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for default headers before appending to cors header failures #4015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saska
Copy link

@saska saska commented Feb 18, 2025

Description

  • Some clients sometimes apparently (AFAIK needlessly) check OPTIONS even if they only have CORS-safelisted headers to ask about; I ran into this with Dio. I see no reason to allow I guess?

Closes

@saska saska requested review from a team as code owners February 18, 2025 20:14
@saska saska changed the title check for default headers before appending to cors header failures fix: check for default headers before appending to cors header failures Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (6768845) to head (7861c3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4015   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         347      347           
  Lines       15783    15783           
  Branches     1745     1745           
=======================================
  Hits        15523    15523           
  Misses        124      124           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saska
Copy link
Author

saska commented Feb 18, 2025

i.e. dio sent this OPTIONS
image

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant