Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native MySQL dumper #31

Merged
merged 12 commits into from
Aug 9, 2024
Merged

Native MySQL dumper #31

merged 12 commits into from
Aug 9, 2024

Conversation

liweiyi88
Copy link
Owner

@liweiyi88 liweiyi88 commented Jul 21, 2024

Add the native mysql dumper to enable mysql users to use onedump without mysqldump dependency

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 73.73358% with 140 lines in your changes missing coverage. Please review.

Project coverage is 77.79%. Comparing base (33f30a5) to head (5d7c4a0).

Files Patch % Lines
dumper/mysqlnativedump.go 73.35% 76 Missing and 13 partials ⚠️
dumper/pgdump.go 48.83% 22 Missing ⚠️
dumper/mysqldump.go 67.56% 10 Missing and 2 partials ⚠️
dumper/runner/ssh.go 60.00% 8 Missing and 4 partials ⚠️
testutils/ssh.go 76.92% 2 Missing and 1 partial ⚠️
handler/jobhandler.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   78.98%   77.79%   -1.20%     
==========================================
  Files          20       23       +3     
  Lines         947     1333     +386     
==========================================
+ Hits          748     1037     +289     
- Misses        136      227      +91     
- Partials       63       69       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liweiyi88 liweiyi88 marked this pull request as ready for review August 9, 2024 01:28
@liweiyi88 liweiyi88 changed the title Native mysqldump Native MySQL dumper Aug 9, 2024
@liweiyi88 liweiyi88 merged commit f49504b into main Aug 9, 2024
4 checks passed
@liweiyi88 liweiyi88 deleted the native-mysqldump branch August 9, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant