No detection of changes when library contains hyphens

[ensc]

When trying to keep nice filenames with hyphens, cargo-c creates both the wanted files and mess from cargo ('-' replaced by '_').

E.g. after

[package.metadata.capi.library]
name = "test-foo"

there will be created (when building from scratch)

libtest-foo.a
libtest-foo.so
libtest_foo.a
libtest_foo.so

When doing changes, only the underscore variants will be rebuilt. Then the hash function calculates the hash function over the requested files (which have not been changed) to see if something changed and exits without regenerating headers.

E.g. content of build directory is (note the dates)

-rw-r--r--. Feb 10 18:52 libtest-foo.a
-rwxr-xr-x. Feb 10 18:52 libtest-foo.so
-rw-r--r--. Feb 10 18:53 libtest_foo.a
-rw-r--r--. Feb 10 18:52 libtest_foo.d
-rwxr-xr-x. Feb 10 18:53 libtest_foo.so

Effect is, that when running cargo cbuild on

#[no_mangle]
pub extern "C" fn add(left: u64, right: u64) -> u64 {
    left + right
}

and changing this later to

#[no_mangle]
pub extern "C" fn sub(left: u64, right: u64) -> u64 {
    left - right
}

the generated wrapper header still contains

uint64_t add(uint64_t left, uint64_t right);

but not sub().

[lu-zero]

It is a duplicate of #208 if you feel like to send a PR I'll be grateful, otherwise I hope to address it one of the future weekends

[lu-zero]

Should be fixed now

[ensc]

problem still happens with 90c6024

Issue seems to be that the library is created both with dashes and underscores:

• on first cargo cbuild, libtest-foo.a + libtest_foo.a are created
• on second cargo cbuild (and after changing the interface), only libtest_foo.a will be updated but libtest-foo.a stays as-is. Hash is calculated over libtest-foo.a and does not change so that .h won't be updated.

cargo 1.86.0-nightly (2928e3273 2025-02-07)

[lu-zero]

if you change the metadata now the resulting hash must change...

[ensc]

I do not change the metadata; I change the source (e.g. add a fn sub() in src/lib.rs); the generated header will not be updated and contains the old content.

[lu-zero]

Ah, then it is even simpler to fix.

[lu-zero]

Please confirm, I'd cut the release next weekend :)