Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow debug symbols install to be skipped if they are not present #382

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

amyspark
Copy link
Contributor

Hi,

This PR is to address an issue found in AOMediaCodec/libavif#2228 (comment) . PDB symbols being missing (due to the release profile or strip being set) should not cause an install failure.

Let me know what you think.

@amyspark amyspark force-pushed the make-missing-pdb-not-fail-install branch from 34f4423 to 3223255 Compare June 26, 2024 14:37
@lu-zero lu-zero merged commit a128f77 into lu-zero:master Jun 26, 2024
14 checks passed
@lu-zero
Copy link
Owner

lu-zero commented Jun 26, 2024

This weekend I will cut a 0.10.1 with this fix.

@wantehchang
Copy link

Thank you for the fix. I have tested this commit in AOMediaCodec/libavif#2228. Now the rav1e build succeeds with the following messages in the output log (please expand "Build libavif (ninja)"):

  Installing pkg-config file
  Installing header file
  Installing static library
      Absent debugging information

Note that "Absent" is not aligned with "Installing". Is that indentation expected?

@lu-zero
Copy link
Owner

lu-zero commented Jun 26, 2024

Yes, the first word is a tag. probably it could be made a a debug message instead though..

@wantehchang
Copy link

Did you mean the "Installing" tag is not indented, but the "Absent" tag is indented?

@lu-zero
Copy link
Owner

lu-zero commented Jun 27, 2024

The first word is a right-aligned tag that has a color (green), the rest is a left-aligned message.

https://docs.rs/cargo/0.80.0/cargo/core/shell/struct.Shell.html#method.status

@wantehchang
Copy link

Thank you for the explanation. I didn't notice that 'Installing" and "Absent" are right-aligned. I only looked on the left.

@lu-zero
Copy link
Owner

lu-zero commented Jun 27, 2024

image

You should notice it with cargo itself as well :)

@amyspark amyspark deleted the make-missing-pdb-not-fail-install branch September 10, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants