Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Cargo.lock for reproducible builds and revert cc crate to 1.2.7 to fix osx build issue #437

Closed
wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Jan 11, 2025

  • add Cargo.lock for reproducible builds (as the project has binary artifacts, it does make sense also checkin the lockfiles for reproducible builds)
  • also revert cc crate to 1.2.7 (seeing some macos sdk detection issue with 1.2.8 release on the homebrew side)

cc crate 1.2.8 error log ref

  warning: [email protected]+1.61.0: ToolExecError: Command env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx15.2" "-I" "nghttp2/lib/includes" "-I" "/private/tmp/cargo-c-20250111-7579-cqlrm/cargo-c-0.10.8/target/release/build/libnghttp2-sys-30549b8c9f7bcb4d/out/i/include" "-DNGHTTP2_STATICLIB" "-DHAVE_NETINET_IN" "-DHAVE_TIME_H" "-DHAVE_ARPA_INET_H" "-o" "/private/tmp/cargo-c-20250111-7579-cqlrm/cargo-c-0.10.8/target/release/build/libnghttp2-sys-30549b8c9f7bcb4d/out/i/lib/64375acaab57ea54-sfparse.o" "-c" "--" "nghttp2/lib/sfparse.c" with args clang did not execute successfully (status code exit status: 1).cargo:warning=clang: error: no such file or directory: '-isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk'

relates to:

@chenrui333 chenrui333 changed the title feat: add Cargo.lock for reproducible builds feat: add Cargo.lock for reproducible builds and revert cc crate to 1.2.7 to fix osx build issue Jan 11, 2025
@lu-zero
Copy link
Owner

lu-zero commented Jan 12, 2025

I consider having Cargo.lock in the tree more problems than its advantages, if we have to pin cc I'd do it otherwise.

@lu-zero
Copy link
Owner

lu-zero commented Jan 12, 2025

I'd just bump to ensure we use the version with this rust-lang/cc-rs#1364 in

@chenrui333
Copy link
Contributor Author

I consider having Cargo.lock in the tree more problems than its advantages

what are the problems?

@chenrui333
Copy link
Contributor Author

I'd just bump to ensure we use the version with this rust-lang/cc-rs#1364 in

yeah, if there is lockfile, then it would be tricky to pin or downgrade crates like cc.

@lu-zero
Copy link
Owner

lu-zero commented Jan 12, 2025

I consider having Cargo.lock in the tree more problems than its advantages

what are the problems?

In general it causes additional churn for us upstream for next to no downstream gain since people should either use the source distribution from crates.io and/or, if upstream is slow at releasing, they still have to maintain their own lockfile.

@lu-zero
Copy link
Owner

lu-zero commented Jan 12, 2025

the updated cc is up now :)

@lu-zero lu-zero closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants