Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cargo version #449

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Bump cargo version #449

merged 3 commits into from
Feb 22, 2025

Conversation

lu-zero
Copy link
Owner

@lu-zero lu-zero commented Feb 21, 2025

No description provided.

@lu-zero
Copy link
Owner Author

lu-zero commented Feb 21, 2025

@amyspark can you figure out what broke for msvc ^^; ?

@sdroege
Copy link
Contributor

sdroege commented Feb 21, 2025

AFAIU it's missing linking to ws2_32.dll or how it was called

@amyspark
Copy link
Contributor

AFAIU it's missing linking to ws2_32.dll or how it was called

Yes, this should've been exposed by the native-static-libs of rustc, I'll need to switch into Windows and get 1.85 to verify.

@amyspark
Copy link
Contributor

@lu-zero merging this beforehand should take care of it: #450

The issue was that pkg-config takes precedence over pkgconf in Meson, and for some reason the recent install also began pulling the former.

@lu-zero
Copy link
Owner Author

lu-zero commented Feb 21, 2025

the problem seems to persist :/

@amyspark
Copy link
Contributor

Ah, you're bumping the cargo version! I hadn't noticed that on top of pkg-config causing its own errors. One moment...

@amyspark
Copy link
Contributor

This result is from cargo 0.86 and it's plainly wrong:

imagen

@lu-zero
Copy link
Owner Author

lu-zero commented Feb 21, 2025

can you check what rustc is emitting?

@amyspark
Copy link
Contributor

I'm doing that, and it's weird:

  • If I run cargo cbuild, the correct information is emitted both to the -uninstalled and final modules
  • But if I run cargo cinstall afterwards, the information is overridden with emptiness
  • Running cargo cinstall results in emitting the correct information directly

Investigating now what's the difference between (1) and (2).

@lu-zero
Copy link
Owner Author

lu-zero commented Feb 21, 2025

Can you confirm that before the cargo update the problem appears?

@amyspark
Copy link
Contributor

@lu-zero Regression here: #446 , the second try doesn't execute rustc (because it's all already built and cached) so no native-static-libs makes it to cbuild. That empties the Libs.private field.

@lu-zero
Copy link
Owner Author

lu-zero commented Feb 21, 2025

Thank you for finding the problem now it will be fun to do the proper cache invalidation...

@lu-zero lu-zero merged commit 144defa into master Feb 22, 2025
34 checks passed
@lu-zero lu-zero deleted the cargo-0.86 branch February 22, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants