Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: Move examples -> _examples and exclude submodules from sonar #12

Merged
merged 20 commits into from
Aug 14, 2024
Merged

workflow: Move examples -> _examples and exclude submodules from sonar #12

merged 20 commits into from
Aug 14, 2024

Conversation

andrewwormald
Copy link
Collaborator

@andrewwormald andrewwormald commented Aug 9, 2024 •
edited
Loading

There are a few submodules that need to be excluded for sonar clouds reporting as it's currently not running those tests. The example package is also being moved to _example to be more neatly excluded

@andrewwormald andrewwormald changed the title Increase coverage to all adapters in workflow core repo workflow: Increase coverage to all adapters in workflow core repo Aug 9, 2024
@andrewwormald andrewwormald marked this pull request as ready for review August 9, 2024 15:22
@andrewwormald andrewwormald changed the title workflow: Increase coverage to all adapters in workflow core repo workflow: Exclude adapters and example dir Aug 12, 2024
echarrod
echarrod reviewed Aug 12, 2024
View reviewed changes
@andrewwormald andrewwormald changed the title workflow: Exclude adapters and example dir workflow: Move examples back to core package and remove external examples Aug 13, 2024
@andrewwormald andrewwormald changed the title workflow: Move examples back to core package and remove external examples workflow: Move examples -> _examples and exclude submodules from sonar Aug 13, 2024
echarrod
echarrod reviewed Aug 13, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrewwormald andrewwormald merged commit e060c07 into main Aug 14, 2024
5 checks passed
@andrewwormald andrewwormald deleted the andreww-extendTestCoverageReportingToAdapters branch August 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarrod echarrod echarrod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewwormald @echarrod