feature: optional argument to manually set dt #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lundberg
reviewed
Oct 4, 2019
There was a problem hiding this comment.
Hello,
Thank you for taking the time to create this PR, I really appreciate it. This seems like a good feature to support.
When the small typo I found is fixed, could you rebase your commits into one single commit? Let me know if you don't know what I mean by this and I will explain. When you are done I will merge your changes.
|
Hi, I committed the fixes and squashed them into a single commit. |
|
This feature is now included in version 0.2.4 of the library |
|
Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PID controllers in simulation, the timestep used for PID calculation should be set to simulation time instead of how long it actually takes between calls to PID().
This PR addresses it by adding a new optional argument that lets the user designate dt themselves.