Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Use executor type from pipeline level when block level executor is not set #4968

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

wangxiaoyou1993
Copy link
Member

Description

Use executor type from pipeline level when block level executor_type is not set

Close: #4965

How Has This Been Tested?

  • Tested in local k8s cluster and set executor_type at pipeline level

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Apr 19, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit 02db3a3 into master Apr 19, 2024
11 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/k8s-pipeline-executor branch April 19, 2024 23:55
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
…is not set (mage-ai#4968)

* [xy] Use executor type from pipeline level when block level executor_type is not set.

* [xy] Only fetch pipeline executor type when block executor_type is not set.

* [xy] Cache the pipeline executor_type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local python to K8s transformer
1 participant