Update vapoursynth and other dependencies #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we do a point release before merging this, since the only downside of this is that we're unable to publish to crates.io. It wouldn't be a bad idea anyway to get the mkvmerge fixes out there. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
shssoichiro
force-pushed
the
update-vs
branch
from
f9f5bda to
228b8a1
Compare
|
@shssoichiro So I guess this is good to merge now? |
shssoichiro
approved these changes
Jan 17, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
(cherry picked from commit d893cd5)
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
(cherry picked from commit d893cd5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vapoursynth crate is still running on the deprecated failure crate. In my fork, I updated to thiserror + anyhow, and migrated to edition 2021. I opened a PR upstream: YaLTeR/vapoursynth-rs#14
Not sure whether we want to leave this PR open until these changes are merged upstream or just merge it now (as this change reduces the number of dependencies by ~20). @shssoichiro thoughts?