Rework log levels to be more useful #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that there is still some colored info printed while not running in a tty, namely the params, warn for rate control for aomenc, just the message for "Scene detection", and the queue, workers, passes message. Perhaps we should fix that too? |
- Update log levels so that the log file contains more verbose information by default, while leaving the stderr progress indicator relatively uncluttered - Explicitly set the log level to `error` for all dependencies - rav1e scenechange info has been moved to `--log-level trace` - Avoid outputting colors if stderr is not a tty - Fix a crash when using `--quiet`
shssoichiro
force-pushed
the
log-levels-refactor
branch
from
58cec57 to
d68e4ad
Compare
|
@redzic Ping. I pushed up the changes you requested. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
- Update log levels so that the log file contains more verbose information by default, while leaving the stderr progress indicator relatively uncluttered - Explicitly set the log level to `error` for all dependencies - rav1e scenechange info has been moved to `--log-level trace` - Avoid outputting colors if stderr is not a tty - Fix a crash when using `--quiet` (cherry picked from commit 351d19a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
information by default, while leaving the stderr progress indicator
relatively uncluttered
errorfor all dependencies--log-level trace--quiet