Lastrosade sc only

[lastrosade]

This pull request adds the --sc-only boolean argument which forces av1an to stop after scene detection as per #573

Right now it simply deletes the temporary directory after the run

What would be optimal would be to not create any temp dir if both:

1. The input is a vpy script.
2. -s is specified.

[redzic]

It looks like the formatting check failed, run cargo fmt to fix the formatting and then push the commit

[lastrosade]

Do I need to write unit tests?

[redzic]

I'm not exactly sure how you would write a unit test for this, but we can add an integration test instead (which are in .github/workflows/tests.yml).

[redzic]

Perhaps we should require -s to be specified if --sc-only is set?

[lastrosade]

Yes, let me try to figure that out.

[redzic]

@lastrosade The easiest way to do it would probably be with this method: https://docs.rs/clap/3.1.0/clap/struct.Arg.html#method.requires_if

[lastrosade]

This is a train wreck

[lastrosade]

It seems that requires_if only wants strings, maybe I need requires_all

[lastrosade]

I figured it out, it was dumb and simple but for some reason I try to over complicate things.

[lastrosade]

The integration test failed with Error: Failed to parse scenes file "tt_sif.json", this likely means that the scenes file is corrupted I doubt this has anything to do with my patch.

Is the video generating an empty scene file?
I'll test this out.

[lastrosade]

running the same test on the same file works fine for me.

[shssoichiro]

It seems the error is coming from this branch:

let (mut scenes, frames) = if (self.scenes.is_some() && scene_file.exists()) || self.resume {
  used_existing_cuts = true;
  crate::split::read_scenes_from_file(scene_file.as_ref())?
}

Which should only get hit if the scenes file already exists prior to running your test command. It shouldn't be... so this is a bit weird.

Just to prove we're not insane, could you try to rm tt_sif.json prior to calling av1an in your CI test?

[lastrosade]

It did not fix it

[master-of-zen]

Looks good to me