Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ffmpeg 5.0 #575

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Update to ffmpeg 5.0 #575

merged 2 commits into from
Feb 22, 2022

Conversation

redzic
Copy link
Collaborator

@redzic redzic commented Feb 18, 2022

  • Also rename ffmpeg-next in Cargo.toml, and refer to our own ffmpeg module by crate::ffmpeg

@shssoichiro
Copy link
Collaborator

Tests do not seem to like that...

Error: ffmpeg: failed to get pixel format for input video "tt_sif.y4m"

@shssoichiro
Copy link
Collaborator

Does the CI runner also need to be on ffmpeg 5? Could that potentially cause this issue?

@redzic
Copy link
Collaborator Author

redzic commented Feb 18, 2022

Actually I can reproduce the CI failure locally as well... so I'm not sure exactly what's wrong. I'll try to debug the issue further.

@redzic
Copy link
Collaborator Author

redzic commented Feb 21, 2022

It now runs fine for me locally (and all-tests seem to pass as well), but it looks like there's an issue with compiling on the docker container?

@master-of-zen
Copy link
Owner

Works now))

@master-of-zen master-of-zen self-requested a review February 22, 2022 20:16
Copy link
Owner

@master-of-zen master-of-zen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job :)

@master-of-zen master-of-zen merged commit 6634bc7 into master-of-zen:master Feb 22, 2022
master-of-zen pushed a commit that referenced this pull request Feb 22, 2022
* Update to ffmpeg 5.0
@redzic redzic deleted the ffmpeg-50 branch February 22, 2022 20:57
@svenstaro
Copy link
Contributor

@master-of-zen Could we get a new release containing this update? I'd like to build av1an against ffmpeg in Arch in order to prepare for the drop of ffmpeg4.4 and av1an is currently one of the blocking packages.

@shssoichiro
Copy link
Collaborator

It looks like we'll need new releases of rav1e, av-scenechange, vapoursynth-rs, and console, since we are still depending on git versions of those. I can push for a release on the first two. Not sure about the latter two.

@svenstaro
Copy link
Contributor

Alright so let's get the ball rolling then. Someone with power should probably do a checklist to keep track of what needs releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants