-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README.md #608
Updated README.md #608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this looks fine, just a couple of cleanup items.
It looks like you're requesting to merge into a branch that isn't master, and I think you have to rebase your PR onto the current master as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, thanks for the cleanup.
I intended to contribute to the master branch, and I'm also sorry but this is my first time ever contributing to any kind of project here and don't yet know how to rebase my PR to the current master too. Any kind of guidance/help would be appreciated. |
I think for this PR you first need to change the base branch back to master through the github UI, and then in the terminal do something like this:
And then push your changes back to your branch through the terminal. Let me know if that works for you |
I've tried it but changed my mind about it since if I change the base to master then there are other files from the branch I'm committing from that are going to be pushed to the master when I don't intend to. |
I think you have to change the base branch, since if you leave it as-is, if we merge the PR the master branch will not actually be changed, only the |
I also never used Git before. |
Co-authored-by: redzic <[email protected]> Co-authored-by: Josh Holmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I went ahead and rebased your PR for you since in this case it was a bit tricky since there were merge conflicts, hopefully that is OK with you. The PR looks good now though, thanks!
I have tried to improve the wording for the README.md file and section of the repository.
Generally, beside improved wording, some specific changes are:
(Also marked as required for "Target Quality" mode. But correct me if I was wrong)