Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement alternate input for scene detection #631

Closed
wants to merge 2 commits into from

Conversation

BlueSwordM
Copy link
Contributor

This patch came from this av1an branch made by @redzic
https://github.com/master-of-zen/Av1an/tree/input-sc

I just refactored to make it work on master, but that's about it.

I've been using it for months(always on the same input source), and it's been working well to prevent my Vapoursynth filters from wrecking the scene detection speed, and I haven't had any problems.

We can expand this to make it work for other kind of inputs(ffmpeg) and make it work in target-quality, but otherwise, that's fine :)

shssoichiro
shssoichiro previously approved these changes May 13, 2022
Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not

@shssoichiro shssoichiro dismissed their stale review May 13, 2022 01:18

Looks like tests are failing. I'll approve after they are passing, since av1an has auto-merging.

@redzic
Copy link
Collaborator

redzic commented May 13, 2022

There are 2 slight issues with this at the moment.

  1. If there is a different frame count, we get a panic message (something like thread 'main' panicked at 'scenecut reported at index 22320, but there are only 144 frames', av1an-core/src/split.rs:58:5). Ideally this error message could be improved on.
  2. Since we now support multiple inputs, maybe make it work for multiple inputs somehow or maybe explicitly only allow this option to be used when a single input is being used.

@BlueSwordM
Copy link
Contributor Author

Personally, even if the tests passed, I'd wait until redzic can come in and see what he can make better :)

@redzic
Copy link
Collaborator

redzic commented May 18, 2022

So @BlueSwordM since you opened this PR, would you like to try to address the issues or do you want me to reopen it and try to work on it?

@BlueSwordM
Copy link
Contributor Author

Yeah, you can do it if you want.

I'm currently working in other stuff not related to AV1 and video stuff at all, so it would be appreciated @redzic

@redzic
Copy link
Collaborator

redzic commented May 18, 2022

Sounds good, I just wanted to ask so that the PR doesn't just sit for a long time with nothing happening. I'll try to work on this whenever I am able to make time for it.

@BlueSwordM
Copy link
Contributor Author

I see this needs to be refactored since I'm seriously restarting my encodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants