-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement alternate input for scene detection #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why not
Looks like tests are failing. I'll approve after they are passing, since av1an has auto-merging.
There are 2 slight issues with this at the moment.
|
Personally, even if the tests passed, I'd wait until redzic can come in and see what he can make better :) |
So @BlueSwordM since you opened this PR, would you like to try to address the issues or do you want me to reopen it and try to work on it? |
Yeah, you can do it if you want. I'm currently working in other stuff not related to AV1 and video stuff at all, so it would be appreciated @redzic |
Sounds good, I just wanted to ask so that the PR doesn't just sit for a long time with nothing happening. I'll try to work on this whenever I am able to make time for it. |
I see this needs to be refactored since I'm seriously restarting my encodes. |
This patch came from this av1an branch made by @redzic
https://github.com/master-of-zen/Av1an/tree/input-sc
I just refactored to make it work on master, but that's about it.
I've been using it for months(always on the same input source), and it's been working well to prevent my Vapoursynth filters from wrecking the scene detection speed, and I haven't had any problems.
We can expand this to make it work for other kind of inputs(ffmpeg) and make it work in target-quality, but otherwise, that's fine :)