Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow for Windows x64 builds #638

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

FreezyLemon
Copy link
Contributor

Starting point for #530.
Builds an x64 executable and uploads it as a workflow artifact (example run)

The exact workflow trigger is still open for discussion. And maybe there's some way to automatically add the artifact to a release? Haven't looked into it yet, this is just the build.

Dependencies:

  • Visual C++ Build Tools: pre-installed
  • Python 3.10: pre-installed + setup by action for proper env variables
  • NASM: Installed by action
  • FFmpeg: Manual download (gyan.dev), cached via file hash
  • VapourSynth: Manual download, cached via release version

Cargo packages are also cached. NASM could also be cached, but I didn't see it as a high priority.

Happy to hear your thoughts

@redzic
Copy link
Collaborator

redzic commented Jun 20, 2022

Thanks! I'm not sure why the clippy tests are failing now and not before, but I've opened #639 to fix it. Rebasing after that should in theory fix the CI failures.

Copy link
Collaborator

@redzic redzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a starting point, thanks! Perhaps we could figure out how to automatically attach build artifacts to releases in a future PR.

@mergify mergify bot merged commit 8f617ec into master-of-zen:master Jun 26, 2022
@FreezyLemon FreezyLemon deleted the ci-win-build branch June 26, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants