Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generating photon noise tables for rav1e #655

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Allow generating photon noise tables for rav1e #655

merged 2 commits into from
Aug 2, 2022

Conversation

shssoichiro
Copy link
Collaborator

Note that the --photon-noise-table flag in rav1e is currently behind the unstable feature, so rav1e must be compiled with --features unstable for this to be supported.

CartoonFan
CartoonFan approved these changes Aug 1, 2022
View reviewed changes
Copy link

@CartoonFan CartoonFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptive changes look fine. I don't know anything about the actual code, though.

BlueSwordM
BlueSwordM approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@BlueSwordM BlueSwordM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good, although it should be noted that the only way to get grain synth inputs to work with rav1e are to build it with "unstable" features.

master-of-zen
master-of-zen approved these changes Aug 2, 2022
View reviewed changes
Copy link
Owner

@master-of-zen master-of-zen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing:) 👍 🥇

@mergify mergify bot merged commit c44f779 into master-of-zen:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlueSwordM BlueSwordM BlueSwordM approved these changes

@CartoonFan CartoonFan CartoonFan approved these changes

@master-of-zen master-of-zen master-of-zen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shssoichiro @BlueSwordM @CartoonFan @master-of-zen