Fix CI Windows builds #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like |
|
Ok, this can be merged after #658. |
redzic
force-pushed
the
win-build-fix-ffmpeg
branch
from
6eb1235 to
3f296c3
Compare
redzic
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After FFmpeg release 5.1, gyan.dev updated their "latest" release from 5.0.1 to 5.1, which currently breaks the build (
ffmpeg-nextandffmpeg-sys-nextdon't support 5.1 yet). To circumvent this in the future, I've fixed the version to 5.0.1 and switched to the GitHub mirror (older releases get removed from gyan.dev at some point).This requires removing the cache functionality, because there's no way to get a file hash from GitHub release assets. This doesn't affect the build time much though.
I've tested this on my fork already, and it works without a problem.
Ignore the 2 commits, I'm just too lazy to squash them manually :D