Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional flags, options #671

Merged
merged 13 commits into from
Jun 25, 2023
Merged

Conversation

woot000
Copy link
Contributor

@woot000 woot000 commented Sep 30, 2022

This commit adds:

  • Never overwrite -n flag, acts as the opposite of the overwrite -y flag
  • Scaler selector --scaler flag, allows the user to choose any scaler available within ffmpeg, including defining the width of the lanczos scaler by typing lanczos1 through lanczos9 (could go higher but there's not really a point to have width values above 6)
  • Extra splits in seconds --extra-splits-sec flag, allows the user to define the maximum scene length in seconds (frames takes precedent if both are defined because the clap crate can't make these options conflict with each other, for some reason)
  • Ignore frame mismatch warning --ignore-frame-mismatch flag, allows the user to ignore any frame mismatch warning in case an ffmpeg filter changes the frame count, or if the input file is badly encoded (acts as a workaround for Unable to change video fps #650)
  • Additional option "inputres" for --vmaf-res, sets the VMAF resolution to be the same as the input video's resolution if --vmaf-res inputres is used
  • Different progress bar characters for Windows, all the characters display correctly on the default Windows command prompt

@mqudsi
Copy link
Contributor

mqudsi commented Feb 3, 2023

I've rebased this on top of master here: https://github.com/mqudsi/Av1an/tree/pr671

Acts as the opposite of the overwrite -y flag
This allows the user to control which scaling algorithm is used during scene detection downscaling and VMAF calculations, and also allows the width of the lanczos scaler to be selected from 1 to 9
This allows the user to have VMAF calculations use the input resolution automatically, without having to type it in manually per file
This looks smoother on the default Windows command prompt
Allows the user to specify extra splits in seconds. If both frames and seconds are specified, frames will take priority
Allows the user to ignore any reported frame mismatches between the encoder and chunk frame counts, which is useful if an ffmpeg filter changes the frame count, or the input video is encoded badly (ex. "Missing key frame while searching for timestamp" ffmpeg warning)
@woot000
Copy link
Contributor Author

woot000 commented Feb 24, 2023

Rebased again (thanks @mqudsi) with some misc. minor changes, a typo correction, and added documentation to CLI.md

@woot000 woot000 reopened this Feb 24, 2023
@woot000 woot000 force-pushed the more-opts branch 3 times, most recently from 6f0fd95 to 5543ceb Compare June 10, 2023 00:44
@shssoichiro shssoichiro merged commit e10880d into master-of-zen:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants