Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move audio size to progress bar OnceCell #754

Merged
merged 1 commit into from
May 9, 2023
Merged

Move audio size to progress bar OnceCell #754

merged 1 commit into from
May 9, 2023

Conversation

master-of-zen
Copy link
Owner

This removes passing of audio_byte through functions and instead use functions from progress bar module to set and get static audio size bytes

shssoichiro
shssoichiro approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better

@master-of-zen master-of-zen merged commit 133f36b into master May 9, 2023
@master-of-zen master-of-zen deleted the move-audio-size-out-of-functions branch May 9, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@master-of-zen @shssoichiro