Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustc 1.71 clippy lints #775

Merged
merged 1 commit into from
Jul 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion av1an-core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#![allow(clippy::doc_markdown)]
#![allow(clippy::items_after_statements)]
#![allow(clippy::wildcard_imports)]
#![allow(clippy::drop_ref)]
#![allow(clippy::unsafe_derive_deserialize)]
#![allow(clippy::needless_pass_by_value)]
#![allow(clippy::use_self)]
Expand Down
6 changes: 0 additions & 6 deletions av1an-core/src/target_quality.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,8 @@ impl TargetQuality {
let mut vmaf_cq = vec![];
let frames = chunk.frames();

let mut q_list = vec![];

// Make middle probe
let middle_point = (self.min_q + self.max_q) / 2;
q_list.push(middle_point);
let last_q = middle_point;

let mut score =
Expand All @@ -66,8 +63,6 @@ impl TargetQuality {
self.max_q
};

q_list.push(next_q);

// Edge case check
score = read_weighted_vmaf(self.vmaf_probe(chunk, next_q as usize)?, VMAF_PERCENTILE).unwrap();
vmaf_cq.push((score, next_q));
Expand Down Expand Up @@ -118,7 +113,6 @@ impl TargetQuality {
break;
}

q_list.push(new_point as u32);
score = read_weighted_vmaf(self.vmaf_probe(chunk, new_point)?, VMAF_PERCENTILE).unwrap();
vmaf_cq.push((score, new_point as u32));

Expand Down