Add a PROGMEM variant createCharPgm() #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathertel
requested changes
May 23, 2022
|
FWIW: LiquidCrystalIO has createCharPgm, LiquidCrystal_I2C has createChar_PAm 23.05.2022 21:17 schrieb Matthias Hertel ***@***.***>:
@mathertel requested changes on this pull request.
the usual naming would be createChar_P but implementation fits.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Allow data for custom characters to be stored in PROGMEM on the AVR platform. Like the NewLiquidCrystal library, we also offer a variant of createChar() which _assumes_ PROGMEM if the data type is const.
markisch
force-pushed
the
feature-createCharPgm
branch
from
5a9291e to
6d42a6d
Compare
|
Changed as requested and included an update to keywords.txt |
mathertel
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow data for custom characters to be stored in PROGMEM on the AVR platform.
Like the NewLiquidCrystal library, we also offer a variant of createChar
which assumes PROGMEM if the data type is const.