Use unsigned 8bit instead of signed 16bit integers #25
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
However the 8bit code makes the resulting codfe bigger and slower on modern cpu architectures. |
|
you requests for multiple pull requests resulting in some conflicts now. Please resolve... |
|
Can you also please add some documentation to the readem file |
All function parameters need to be positive and 8bit only. So using uint8_t instead of signed 16bit integers not only makes the code and memory size smaller on 9bit platforms, but also is in line with the original LiquidCrystal library.
|
Thanks, I will test more next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All function parameters need to be positive and 8bit only. So using uint8_t
instead of signed 16bit integers not only makes the code and memory size
smaller, but also is in line with the original LiquidCrystal library.