Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CreateChar (int, int[]) to (int, byte[]) #9

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

Gasman2014
Copy link
Contributor

Adjusted CreateChar to use byte charmap.

@eddyp
Copy link
Contributor

eddyp commented Dec 11, 2019

I agree with these changes, especially since the int usage is gratuitous and the upper byte is lost when passed to write.

@eddyp
Copy link
Contributor

eddyp commented Dec 11, 2019

IMHO, a similar change should be propagated into _send, _sendNibble and _write2Wire for value and halfByte. In the end, the Wire library has some helper members to handle the type mismatches, but they are all eventually mapped to virtual size_t write(uint8_t);.

@mathertel
Copy link
Owner

seams a reasonable change. Thanks for the contribution.

@mathertel mathertel merged commit b3b83e7 into mathertel:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants