validate we can use aliases with type arguments

matryer · Aug 24, 2024 · c110da7 · c110da7
1 parent c7f4a31
commit c110da7
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/pkg/moq/testpackages/typealias/typealias.go b/pkg/moq/testpackages/typealias/typealias.go
@@ -5,5 +5,5 @@ import (
 )
 
 type Example interface {
-	Do(a typealiastwo.AliasType) error
+	Do(a typealiastwo.AliasType, b typealiastwo.GenericAliasType) error
 }
diff --git a/pkg/moq/testpackages/typealias/typealias_moq.golden.go b/pkg/moq/testpackages/typealias/typealias_moq.golden.go
diff --git a/pkg/moq/testpackages/typealiastwo/internal/typealiasinternal/typealiasinternal.go b/pkg/moq/testpackages/typealiastwo/internal/typealiasinternal/typealiasinternal.go
@@ -1,6 +1,10 @@
 package typealiasinternal
 
-// we shouldn't be able to import this type directly, you need to use the alias in the parent package
+// we shouldn't be able to import these types directly, you need to use the alias in the parent package
 type MyInternalType struct {
 	Foo int
 }
+
+type MyGenericType[T any] struct {
+	A T
+}
diff --git a/pkg/moq/testpackages/typealiastwo/typealiastwo.go b/pkg/moq/testpackages/typealiastwo/typealiastwo.go
@@ -3,3 +3,5 @@ package typealiastwo
 import "github.com/matryer/moq/pkg/moq/testpackages/typealiastwo/internal/typealiasinternal"
 
 type AliasType = typealiasinternal.MyInternalType
+
+type GenericAliasType = typealiasinternal.MyGenericType[int]
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,3 +3,5 @@ package typealiastwo
		import "github.com/matryer/moq/pkg/moq/testpackages/typealiastwo/internal/typealiasinternal"

		type AliasType = typealiasinternal.MyInternalType
Check failure on line 5 in pkg/moq/testpackages/typealiastwo/typealiastwo.go View workflow job for this annotation GitHub Actions / test (ubuntu-latest, oldstable) `exported type AliasType should have comment or be unexported` Check failure on line 5 in pkg/moq/testpackages/typealiastwo/typealiastwo.go View workflow job for this annotation GitHub Actions / test (ubuntu-latest, stable) `exported type AliasType should have comment or be unexported`

		type GenericAliasType = typealiasinternal.MyGenericType[int]
Check failure on line 7 in pkg/moq/testpackages/typealiastwo/typealiastwo.go View workflow job for this annotation GitHub Actions / test (ubuntu-latest, oldstable) `exported type GenericAliasType should have comment or be unexported` Check failure on line 7 in pkg/moq/testpackages/typealiastwo/typealiastwo.go View workflow job for this annotation GitHub Actions / test (ubuntu-latest, stable) `exported type GenericAliasType should have comment or be unexported`