Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump golang.org/x/tools v0.30.0 #232

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

haunt98
Copy link
Contributor

@haunt98 haunt98 commented Feb 12, 2025

Fix package "context" without types was imported from "xxx/pkg"

See vektra/mockery#535

@sudo-suhas
Copy link
Collaborator

@haunt98 the issue you linked is 2 years old and affects and older version of the library. Did you face the same issue with moq? And have you been able to verify the fix?

@haunt98
Copy link
Contributor Author

haunt98 commented Feb 12, 2025

Hi @sudo-suhas,
After go 1.24 release (https://go.dev/doc/go1.24). I re-build moq then re generate my interface then I encouter this error.

My interface has redis embed like this:

import	"github.com/redis/go-redis/v9"


type Client interface {
	redis.UniversalClient

	SetJSON(ctx context.Context, key string, value any, expired time.Duration) error
	GetJSON(ctx context.Context, key string, value any) error
}

@sudo-suhas
Copy link
Collaborator

Were you able to check if the issue is resolved with the changes in this PR?

@haunt98
Copy link
Contributor Author

haunt98 commented Feb 12, 2025

Yes @sudo-suhas,
I update then go install my fork then re-gen mock without problem

@sudo-suhas sudo-suhas merged commit 0709d7a into matryer:main Feb 12, 2025
4 checks passed
@haunt98
Copy link
Contributor Author

haunt98 commented Feb 12, 2025

Thank you @sudo-suhas!

@haunt98 haunt98 deleted the bump-deps branch February 12, 2025 03:56
@sudo-suhas
Copy link
Collaborator

Released via v0.5.2 🎉

Thanks for the PR @haunt98!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants