Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting things from more than one configuration section with --set, using a configuration transaction. #742

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ianmcorvidae
Copy link
Contributor

@ianmcorvidae ianmcorvidae commented Feb 20, 2025

This should track all the configuration sections that get specified, start a configuration transaction if more than one gets used, and then write each of them and finish the configuration transaction.

Want to test this out? pipx install git+https://github.com/ianmcorvidae/meshtastic-python.git@multiset#egg=meshtastic[cli] --suffix=-multiset then use meshtastic-multiset

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.14%. Comparing base (f41ef04) to head (8529495).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   60.12%   60.14%   +0.01%     
==========================================
  Files          24       24              
  Lines        4053     4062       +9     
==========================================
+ Hits         2437     2443       +6     
- Misses       1616     1619       +3     
Flag Coverage Δ
unittests 60.14% <70.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 2f44351 into meshtastic:master Feb 21, 2025
11 checks passed
@ianmcorvidae ianmcorvidae deleted the multiset branch February 21, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant