Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff config #2583

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Add Ruff config #2583

wants to merge 11 commits into from

Conversation

zas
Copy link
Collaborator

@zas zas commented Feb 23, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested a review from phw February 23, 2025 12:02
@zas
Copy link
Collaborator Author

zas commented Feb 23, 2025

@phw ruff could replace isort, pylint, and flake8 we have configs for, so that's a first step.

I created a separated workflow for now, but we may want to actually replace pylint in existing workflows.
Also I fixed files according to extra warnings I was getting locally, some are quite interesting (like missing @staticmethod I detected because my precommit hook is running flake8, but those weren't catched by ruff afaik), most are cosmetic only.

Those related to raise ... from are trickier, most of times we want to use from parent exception, but in case we actually handle it, so I tried to stick to some ... logic. A review is very needed though ;)

Question: should'nt we write a proper pyproject.toml with a project section now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant