Switch auto initializer targets to add via BeforeClCompileTargets #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iming for picking up added compiler options.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
approved these changes
Jan 4, 2025
Scottj1s
reviewed
Jan 4, 2025
codendone
added a commit
that referenced
this pull request
Jan 10, 2025
… timing for picking up added compiler options. (#5003)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto initializer targets via
<BeforeClCompileTargets>(rather thanBeforeTargets="ClCompile") to get better timing for picking up added compiler options. This helps to ensure they are added after dynmically-added compiler options, such as/arm64ec.A separate
AddUndockedRegFreeWinRTCppDefinestarget was created to ensure those global defines are still added with the same timing they had previously. (I'm not sure if those global defines are required, but that is a question for another day.)